fib/test_fib.py: User IPv6 addresses in outer header for IPinIPHashTest #21308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Rideout <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When running on isolated-v6 testbeds, use IPv6 addressing in the outermost L3 header of IPinIP packets, as IPv4 addresses are not configured and are unresolvable on these testbeds.
Summary:
Fixes #21160
Type of change
Back port request
Approach
What is the motivation for this PR?
This removes an issue caused by a mismatch between test expectations and the testbed configuration, namely the assumption that IPv4 addresses can be used on testbeds that are isolated-v6. This came up during imagequal testing of a different branch and will need to be addressed there as well.
How did you do it?
Evaluate whether or not the testbed is isolated-v6 and safe this in a class attribute. If this attribute is true, pass IPv6 addresses to packet-creation and verification methods so that the L3 addresses in outer headers of IPinIP packets are IPv6. IPv6-specific scapy methods are utilized where applicable.
How did you verify/test it?
Verified that the test case now uses IPv6 addressing in outer IPinIP headers, and that it no longer fails due to nexthop resolution issues.